Supply bot train pulling partial prototype by Mackamuir · Pull Request #5920 · ss14Starlight/space-station-14

Mackamuir · 2026-09-01T03:12:25Z

Short description

Can I just merge the same branch

Why we need to add this

Partials for #5876

Media (Video/Screenshots)

Checks

I do not require assistance to complete the PR.
Before posting/requesting review of a PR, I have verified that the changes work.
I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

coderabbitai · 2026-09-01T03:14:38Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: b8387503-c046-40b4-8d7e-d5287c00cd32

📥 Commits

Reviewing files that changed from the base of the PR and between ad9f3c9 and 59ec7bf.

📒 Files selected for processing (1)

Resources/Prototypes/_Starlight/Partials/Entities/Mobs/NPCs/silicon.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

📝 Summary

Summary

Adds a partial MobSupplyBot prototype for a train-pulling system.

Allows the supply bot to pull up to three train cars.
Adds one paperwork hand slot.
Restricts the slot to documents or items with a Stamp component.
Adds ComplexInteraction.

User impact

Supply bots can support future train-car pulling gameplay and carry paperwork. The implementation is partial and does not define a complete gameplay loop.

Risk areas

The prototype may be incomplete because the train system remains under development.
Existing tests are reported as broken.
The design may need revision because reviewers questioned the current behavior.

Guideline gaps

The PR does not explain the final gameplay scope or rationale for the component combination.
The PR does not document the expected design impact of giving supply bots train-pulling and paperwork capabilities.
The PR does not state whether the MobSupplyBot partial belongs in Starlight rather than Shared.
The PR does not include a Starlight ownership comment.
The PR does not address localization needs for the new paperwork interaction or related user-facing behavior.
The PR does not identify breaking changes.

Walkthrough

Adds a MobSupplyBot partial entity with a three-car pull train, SupplyBot body, restricted paperwork hand, and ComplexInteraction component.

Changes

Supply bot prototype

Layer / File(s)	Summary
Supply bot entity definition `Resources/Prototypes/_Starlight/Partials/Entities/Mobs/NPCs/silicon.yml`	Defines `MobSupplyBot` with `PullTrain`, `Body`, `Hands`, and `ComplexInteraction` components. The paperwork hand accepts `Document`-tagged items or items with a `Stamp` component.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 59ec7

This adds the supply-bot partial configuration without an identified current-head correctness or runtime risk.

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: a partial prototype for a supply bot train pulling system.
Description check	✅ Passed	The description relates the changes to prototype partials for PR `#5876` and explains the absence of media.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Mackamuir · 2026-09-01T03:15:56Z

mm this doesn't feel right I

Conflee · 2026-09-01T03:41:39Z

tests are just broken right now

InanimateIJK · 2026-09-01T05:12:50Z

@walksanatora hi fix tests pls

Mackamuir · 2026-09-03T05:00:54Z

I dont understand why in the diff i'm not seing the removal of the previous prototype in Resources/Prototypes/Entities/Mobs/NPCs/silicon.yml but when I go to that file it's not there :/

walksanatora · 2026-09-03T05:13:52Z

update your branch perhaps?

github-actions · 2026-09-03T05:26:06Z

Content + Integration Test Results

Failed Tests

❌ SpawnAndDeleteAllEntitiesOnDifferentMaps

SERVER: 38.916s [ERRO] resolve: Can't resolve "Robust.Shared.Physics.Components.PhysicsComponent" on entity NanoTrasen navy marine hardsuit helmet (168141/n168141, ClothingHeadHelmetHardsuitNTNCConsortium)!
   at System.Environment.get_StackTrace()
   at Robust.Shared.Physics.Systems.SharedPhysicsSystem.ApplyLinearImpulse(EntityUid uid, Vector2 impulse, FixturesComponent manager, PhysicsComponent body) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Physics/Systems/SharedPhysicsSystem.Components.cs:line 265
   at Content.Shared.Gibbing.GibbingSystem.FlingDroppedEntity(EntityUid target) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Gibbing/GibbingSystem.cs:line 68
   at Content.Shared.Gibbing.GibbingSystem.Gib(EntityUid ent, Boolean dropGiblets, Nullable`1 user) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Gibbing/GibbingSystem.cs:line 51
   at Content.Shared.Trigger.Systems.GibOnTriggerSystem.OnTrigger(Entity`1 ent, EntityUid target, TriggerEvent& args) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Trigger/Systems/GibOnTriggerSystem.cs:line 24
   at DMD<DMD<>?19391102::Robust.Shared.GameObjects.EntityEventBus::EntDispatch>(EntityEventBus this, EntityUid euid, Type eventType, Unit& args)
   at SyncProxy<System.Void Robust.Shared.GameObjects.EntityEventBus:EntDispatch(Robust.Shared.GameObjects.EntityUid, System.Type, Robust.Shared.GameObjects.EntityEventBus+Unit&)>(EntityEventBus , EntityUid , Type , Unit& )
   at Content.Shared.Trigger.Systems.TriggerSystem.Trigger(EntityUid trigger, Nullable`1 user, String key, Boolean predicted) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Trigger/Systems/TriggerSystem.cs:line 80
   at Content.Shared.Trigger.Systems.TriggerOnMobstateChangeSystem.OnMobStateRelay(EntityUid uid, TriggerOnMobstateChangeComponent component, ImplantRelayEvent`1 args) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Trigger/Systems/TriggerOnMobstateChangeSystem.cs:line 37
   at DMD<DMD<>?19391102::Robust.Shared.GameObjects.EntityEventBus::EntDispatch>(EntityEventBus this, EntityUid euid, Type eventType, Unit& args)
   at SyncProxy<System.Void Robust.Shared.GameObjects.EntityEventBus:EntDispatch(Robust.Shared.GameObjects.EntityUid, System.Type, Robust.Shared.GameObjects.EntityEventBus+Unit&)>(EntityEventBus , EntityUid , Type , Unit& )
   at Robust.Shared.GameObjects.EntitySystem.RaiseLocalEvent[TEvent](EntityUid uid, TEvent args, Boolean broadcast) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntitySystem.cs:line 228
   at Content.Shared.Implants.SharedSubdermalImplantSystem.RelayToImplantEvent[T](EntityUid uid, ImplantedComponent component, T args) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Implants/SharedSubdermalImplantSystem.Relays.cs:line 36
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass54_0`2.<SubscribeLocalEvent>g__EventHandler|0(EntityUid uid, IComponent comp, Unit& ev) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 267
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalOrdered(EntityUid uid, Type eventType, EventData subs, Unit& unitRef, Boolean broadcast) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Ordering.cs:line 43
   at Content.Shared.Mobs.Systems.MobStateSystem.ChangeState(EntityUid target, MobStateComponent component, MobState newState, Nullable`1 origin) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Mobs/Systems/MobStateSystem.StateMachine.cs:line 114
   at Content.Shared.Mobs.Systems.MobStateSystem.UpdateMobState(EntityUid entity, MobStateComponent component, Nullable`1 origin) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Mobs/Systems/MobStateSystem.StateMachine.cs:line 37
   at Content.Shared.Mobs.Systems.MobThresholdSystem.OnDamaged(EntityUid target, MobThresholdsComponent thresholds, DamageChangedEvent args) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Mobs/Systems/MobThresholdSystem.cs:line 453
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalOrdered(EntityUid uid, Type eventType, EventData subs, Unit& unitRef, Boolean broadcast) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Ordering.cs:line 43
   at Content.Shared.Damage.Systems.DamageableSystem.ChangeDamage(Entity`1 ent, DamageSpecifier damage, Boolean ignoreResistances, Boolean interruptsDoAfters, Nullable`1 origin, Boolean ignoreGlobalModifiers, Single armorPenetration, Boolean canHeal) in /home/runner/work/space-station-14/space-station-14/Content.Shared/Damage/Systems/DamageableSystem.API.cs:line 134
   at Content.Shared.Body.Systems.SharedBodySystem.PartRemoveDamage(Entity`1 bodyEnt, Entity`1 partEnt) in /home/runner/work/space-station-14/space-station-14/Content.Shared/_Starlight/Medical/Body/Systems/SharedBodySystem.Parts.cs:line 210
   at Content.Server._Starlight.Medical.Body.Systems.BodySystem.RemovePart(Entity`1 bodyEnt, Entity`1 partEnt, String slotId) in /home/runner/work/space-station-14/space-station-14/Content.Server/_Starlight/Medical/Body/Systems/BodySystem.cs:line 84
   at Content.Shared.Body.Systems.SharedBodySystem.OnBodyPartRemoved(Entity`1 ent, EntRemovedFromContainerMessage& args) in /home/runner/work/space-station-14/space-station-14/Content.Shared/_Starlight/Medical/Body/Systems/SharedBodySystem.Parts.cs:line 68
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalOrdered(EntityUid uid, Type eventType, EventData subs, Unit& unitRef, Boolean broadcast) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Ordering.cs:line 43
   at Robust.Shared.Containers.SharedContainerSystem.Remove(Entity`2 toRemove, BaseContainer container, Boolean reparent, Boolean force, Nullable`1 destination, Nullable`1 localRotation) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.Remove.cs:line 101
   at Robust.Shared.Containers.SharedContainerSystem.RemoveEntity(EntityUid uid, EntityUid toremove, ContainerManagerComponent containerManager, TransformComponent containedXform, MetaDataComponent containedMeta, Boolean reparent, Boolean force, Nullable`1 destination, Nullable`1 localRotation) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs:line 258
   at Robust.Shared.Containers.SharedContainerSystem.OnParentChanged(EntParentChangedMessage& message) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs:line 680
   at Robust.Shared.GameObjects.SharedTransformSystem.RaiseMoveEvent(Entity`2 ent, EntityUid oldParent, Vector2 oldPosition, Angle oldRotation, Nullable`1 oldMap, Boolean checkTraversal) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/Systems/SharedTransformSystem.cs:line 286
   at Robust.Shared.GameObjects.SharedTransformSystem.SetCoordinates(Entity`2 entity, EntityCoordinates value, Nullable`1 rotation, Boolean unanchor, TransformComponent newParent, TransformComponent oldParent) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs:line 690
   at Robust.Shared.GameObjects.SharedTransformSystem.DetachEntityInternal(EntityUid uid, TransformComponent xform, MetaDataComponent meta, TransformComponent oldXform, Boolean terminating) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs:line 1749
   at Robust.Shared.GameObjects.EntityManager.RecursiveDeleteEntity(EntityUid uid, MetaDataComponent metadata, TransformComponent transform, TransformComponent parentXform) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 671
   at Robust.Shared.GameObjects.EntityManager.DeleteEntity(EntityUid e, MetaDataComponent meta, TransformComponent xform) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 627
   at Robust.Shared.GameObjects.EntityManager.DeleteEntity(Nullable`1 uid) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 552
   at Content.IntegrationTests.Tests.EntityTest.<>c__DisplayClass6_0.<SpawnAndDeleteAllEntitiesOnDifferentMaps>b__1() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/EntityTest.cs:line 98
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1250
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1237
   at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 773
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) Exception:

Trace:

   at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 28
   at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 99
   at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 107
   at Robust.UnitTesting.Pool.TestPair`2.CleanReturnAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 125
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 260
   at NUnit.Framework.Internal.Commands.SetUpTearDownItem.RunTearDown(TestExecutionContext context)
1)    at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 25
   at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 99
2)    at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 106

Tests 📝	Passed ✅	Failed ❌	Duration ⏱️
1712	1691	1	16m 32s

Github Test Reporter by CTRF 💚

Mackamuir added 4 commits August 30, 2026 13:00

Add Train car pulling system

19c6626

Let them hold paperwork

97c488a

Blehhh partials

db20432

Partial prototype for whenever those come about

0656d3e

Mackamuir requested a review from a team September 1, 2026 03:12

Merge branch 'starlight-dev' into supply_bot_tomfoolery

a8d8e65

github-actions Bot added Changes: No C# size/S labels Sep 1, 2026

Mackamuir closed this Sep 1, 2026

Mackamuir reopened this Sep 3, 2026

Merge branch 'starlight-dev' into supply_bot_tomfoolery

59ec7bf

Navigation Menu

Uh oh!

Supply bot train pulling partial prototype - #5920

Supply bot train pulling partial prototype#5920
Mackamuir wants to merge 6 commits into
ss14Starlight:starlight-devfrom
Mackamuir:supply_bot_tomfoolery

Mackamuir commented Sep 1, 2026

Uh oh!

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading

Summary

User impact

Risk areas

Guideline gaps

Walkthrough

Changes

Uh oh!

Mackamuir commented Sep 1, 2026

Uh oh!

Conflee commented Sep 1, 2026

Uh oh!

InanimateIJK commented Sep 1, 2026

Uh oh!

Mackamuir commented Sep 3, 2026

Uh oh!

walksanatora commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Mackamuir commented Sep 1, 2026

Short description

Why we need to add this

Media (Video/Screenshots)

Checks

Uh oh!

coderabbitai Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

User impact

Risk areas

Guideline gaps

Walkthrough

Changes

Uh oh!

Mackamuir commented Sep 1, 2026

Uh oh!

Conflee commented Sep 1, 2026

Uh oh!

InanimateIJK commented Sep 1, 2026

Uh oh!

Mackamuir commented Sep 3, 2026

Uh oh!

walksanatora commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Content + Integration Test Results

Failed Tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading